fix: update java compatibility #226
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #226 +/- ##
=========================================
Coverage 78.55% 78.55%
Complexity 1069 1069
=========================================
Files 206 206
Lines 5228 5228
Branches 449 449
=========================================
Hits 4107 4107
Misses 813 813
Partials 308 308
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
aaron-steinfeld
requested review from
avinashkolluru,
kotharironak,
skjindal93 and
suresh-prakash
as code owners
| id("org.hypertrace.ci-utils-plugin") version "0.4.0" | ||
| id("org.hypertrace.publish-plugin") version "1.1.1" apply false | ||
| id("org.hypertrace.code-style-plugin") version "2.1.2" apply false | ||
| id("org.hypertrace.java-convention") version "0.4.0" |
There was a problem hiding this comment.
Our java convention plugin decouples the build from the current java version. By default, it uses java 21 to compile but targets compatibility with 11. The current issue is that it's using whatever version was used to run gradle, and CI's default version was updated to 17 by GH.
|
|
||
| testImplementation(libs.org.junit.jupiter.junit.jupiter) | ||
| testImplementation(libs.org.mockito.mockito.core) | ||
| testImplementation(libs.org.mockito.mockito.inline) |
There was a problem hiding this comment.
Newer versions of mockito have this built in. The old version was not compatible with newer java.
No description provided.